Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

515 Support #2113

Merged
merged 49 commits into from
Nov 4, 2023
Merged

Conversation

MarkSuckerberg
Copy link
Member

@MarkSuckerberg MarkSuckerberg commented Jul 1, 2023

About The Pull Request

Regexes used:

 \.proc/(\w+)
 PROC_REF($1)
 
 ([\w/]+?)/?\.proc/(\w+)
 TYPE_PROC_REF($1, $2)

,\.proc/(\w+)
, PROC_REF($1)

,([\w/]+?)/?\.proc/(\w+)
, TYPE_PROC_REF($1, $2)

Taken from yogstation13/Yogstation#18669

Why It's Good For The Game

We gotta update eventually

Changelog

🆑
code: 515 is now supported.
/:cl:

@github-actions github-actions bot added DME Edit Admin They do it for free. GitHub Our very own Babylon. Code change Watch something violently break. labels Jul 1, 2023
@thgvr
Copy link
Member

thgvr commented Jul 1, 2023

thats a lot of files

@MarkSuckerberg
Copy link
Member Author

just a spoonful

@meemofcourse
Copy link
Contributor

what did op mean by this

@Anderson-Cooper
Copy link

i have nothing else to do with my day so i will watch the github checks until it's successful

i believe in you mark

@Anderson-Cooper
Copy link

i have a good feeling about this one

@Anderson-Cooper
Copy link

i have a good feeling about this one

:(

MarkSuckerberg and others added 10 commits July 1, 2023 00:01
## About The Pull Request

It is possible to create a callback whose `object` (the datum it tries
to call) is a path to an external library. Needless to say, it's
probably a bad idea to allow admins to call arbitrary external
libraries. Var-edited callbacks won't be able to reach the point where
the library is executed, but only because `WrapAdminProcCall` runtimes
when trying to call `CanProcCall` on a string, but if there is some way
to call a function that creates a non-varedited callback with an
external library as its object, this PR prevents that.

## Why It's Good For The Game

See above.

## Changelog

:cl:
admin: Admins are unable to invoke functions from external libraries
using callbacks.
/:cl:
It is possible to create a callback whose `object` (the datum it tries
to call) is a path to an external library. Needless to say, it's
probably a bad idea to allow admins to call arbitrary external
libraries. Var-edited callbacks won't be able to reach the point where
the library is executed, but only because `WrapAdminProcCall` runtimes
when trying to call `CanProcCall` on a string, but if there is some way
to call a function that creates a non-varedited callback with an
external library as its object, this PR prevents that.

See above.

:cl:
admin: Admins are unable to invoke functions from external libraries
using callbacks.
/:cl:
This is a byond bug, but @san7890 @lessthnthree found it months ago and
didn't report it to byond.

So I will not open the issue report reporting this byond. They can
fucking do that.

This pr needs a speed merge because we have linux downstreams that
follow upstream code affected by this byond bug. then again skyrat also
knows about this bug on top of this workaround and has not opened a bug
report so maybe they don't fucking need a speed merge and instead should
have filed a bug report with byond.

Its out of my hands.

---------

Co-authored-by: Watermelon914 <[email protected]>
@github-actions github-actions bot added the Config Watch us shake head admins violently until this gets merged. label Jul 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Aug 3, 2023
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 15, 2023
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 19, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MarkSuckerberg MarkSuckerberg marked this pull request as ready for review November 4, 2023 04:29
@MarkSuckerberg MarkSuckerberg requested a review from a team as a code owner November 4, 2023 04:29
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Nov 4, 2023
@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Nov 4, 2023
Merged via the queue into shiptest-ss13:master with commit c6d7e79 Nov 4, 2023
10 checks passed
@MarkSuckerberg MarkSuckerberg deleted the five-fifteen branch November 4, 2023 18:25
MysticalFaceLesS added a commit to CeladonSS13/Shiptest that referenced this pull request Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin They do it for free. Code change Watch something violently break. Config Watch us shake head admins violently until this gets merged. DME Edit GitHub Our very own Babylon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants