-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
515 Support #2113
515 Support #2113
Conversation
Adds support for additional byond versions tests
thats a lot of files |
just a spoonful |
what did op mean by this |
i have nothing else to do with my day so i will watch the github checks until it's successful i believe in you mark |
i have a good feeling about this one |
:( |
## About The Pull Request It is possible to create a callback whose `object` (the datum it tries to call) is a path to an external library. Needless to say, it's probably a bad idea to allow admins to call arbitrary external libraries. Var-edited callbacks won't be able to reach the point where the library is executed, but only because `WrapAdminProcCall` runtimes when trying to call `CanProcCall` on a string, but if there is some way to call a function that creates a non-varedited callback with an external library as its object, this PR prevents that. ## Why It's Good For The Game See above. ## Changelog :cl: admin: Admins are unable to invoke functions from external libraries using callbacks. /:cl:
It is possible to create a callback whose `object` (the datum it tries to call) is a path to an external library. Needless to say, it's probably a bad idea to allow admins to call arbitrary external libraries. Var-edited callbacks won't be able to reach the point where the library is executed, but only because `WrapAdminProcCall` runtimes when trying to call `CanProcCall` on a string, but if there is some way to call a function that creates a non-varedited callback with an external library as its object, this PR prevents that. See above. :cl: admin: Admins are unable to invoke functions from external libraries using callbacks. /:cl:
This is a byond bug, but @san7890 @lessthnthree found it months ago and didn't report it to byond. So I will not open the issue report reporting this byond. They can fucking do that. This pr needs a speed merge because we have linux downstreams that follow upstream code affected by this byond bug. then again skyrat also knows about this bug on top of this workaround and has not opened a bug report so maybe they don't fucking need a speed merge and instead should have filed a bug report with byond. Its out of my hands. --------- Co-authored-by: Watermelon914 <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About The Pull Request
Regexes used:
Taken from yogstation13/Yogstation#18669
Why It's Good For The Game
We gotta update eventually
Changelog
🆑
code: 515 is now supported.
/:cl: